Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11625 closed build error (fixed)

Build fails with libpng 1.4.x

Reported by: vog Owned by:
Priority: blocker Milestone:
Component: build Version: oldstable-latest
Keywords: libpng libpng14 Cc:
Blocked By: Blocking:
Patch: yes

Description

On a system with libpng 1.4.x, a "configure --with-libpng=sys" fails with:


checking for png.h > 0.90...
checking for png.h... yes
checking for png_check_sig in -lpng... no
configure: error: system png library not found or too old! Use --with-libpng=builtin to use built-in version


It checks for the deprecated function png_check_sig(). Since that function isn't used by wxWidgets anyway, checking instead for png_sig_cmp() solves the problem.

The attached patch does exactly that. Note that it changes just configure.ac, so the configure script needs to be recreated after applying the patch.

More information:
http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt

Attachments (1)

fix_libpng14.patch download (543 bytes) - added by vog 4 years ago.
Check for png_sig_cmp() instead of png_check_sig()

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by vog

Check for png_sig_cmp() instead of png_check_sig()

comment:1 follow-up: Changed 4 years ago by vadz

  • Resolution set to port to stable
  • Status changed from new to portneeded

Thank you, will apply in a moment.

It would also be nice to upgrade the libpng version included in our tree, if anybody wants to do it, it would be very welcome.

P.S. I assumed you're the same "vog" as at SF so I used "Volker Grabsch" to credit you in docs/changes.txt, please let me know if I was wrong.

comment:2 Changed 4 years ago by VZ

(In [63137]) Check for a function existing in all libpng releases in configure.

We tested for png_check_sig() which was deprecated and is not available in the
latest libpng 1.4 any more. Just use another, not deprecated and not new,
function for the test.

See #11625.

comment:3 Changed 4 years ago by vadz

  • Resolution changed from port to stable to fixed
  • Status changed from portneeded to closed

Also applied to 2.8 in r63138 (which unfortunately got a completely wrong commit message...).

comment:4 in reply to: ↑ 1 Changed 4 years ago by vog

Replying to vadz:

P.S. I assumed you're the same "vog" as at SF so I used "Volker Grabsch" to credit you in docs/changes.txt, please let me know if I was wrong.

Yes, I'm the same "vog". Thanks for the credit.

Note: See TracTickets for help on using tickets.