Add wxTreeCtrl::SelectAll()

[TNikolay]

Why wxTreeCtrl has UnselectAll(), but does not has SelectAll()? I noticed that there is no direct way correctly write method SelectAll for wxTreeCtrl delivered class without duplicating a lot of private code from wxTreeCtrl class. So I have tried add this method into wxTreeCtrl. Hope it's a correct version.

[vadz]

Thanks for your patch, I agree that adding this method would make sense.

However, as usual, we need:

1. Documentation for the new function (in interface/wx/treectrl.h)
2. Its declaration in the base class
3. Its implementation for the generic version (this is so simple that it really seems a pity to not add it)
4. ideally a test for it in the tree sample

TIA!

[TNikolay]

I did all that, but I see two problems

1. I don't sure that I did all correct for the generic version - somebody who know how it works should check and fix this:)

2. I have added in include/wx/treectrl.h a two pure virtual functions, it seems something should be added to all ports now, in order to compile them?

[vadz]

The patch looks great now, thanks for updating it! I've done just a couple of minor changes, please see my version in the attachment.

But I am confused now: why doesn't the method called SelectAll() actually select all items? I could understand if it selected only the children of the given parent but I don't understand why does it select only the immediate children.

If this is really intentional, the method should be called differently, e.g. SelectChildren() because it's not the opposite of UnselectAll(). But I wonder if this is really intentional and if this behaviour is really useful?

[vadz]

VZ's updated version of the patch

[TNikolay]

I can't imagine situation where we need to select all children. Do you know such user case?

But you are right in general case SelectAll should select all :) What about the following version ?

SelectAll(const wxTreeItemId& parent, bool onlyDirectChildren = true);

I think I can modify code in order to implement this

[vadz]

Replying to TNikolay:

I can't imagine situation where we need to select all children. Do you know such user case?

In my own program I use wxTreeCtrl to present the list of mailboxes. I could see how selecting all of them could be useful if you had an operation which works on all selected folders (I don't and the tree is single selection anyhow but well, it's an example...).

But you are right in general case SelectAll should select all :) What about the following version ?

SelectAll(const wxTreeItemId& parent, bool onlyDirectChildren = true);

I think I can modify code in order to implement this

I  dislike boolean arguments so I still think that it should be renamed to SelectChildren(). I can do it with the existing patch (my version of it) if you agree.

[TNikolay]

In my own program I use wxTreeCtrl to present the list of mailboxes. I could see how selecting all of them could be useful if you had an operation which works on all selected folders (I don't and the tree is single selection anyhow but well, it's an example...).

I think - usually when we doing something with folder we doing this and with all its children (delete, move, drag&drop, get some information etc)... so it is enough to select only direct parent. But it does not matter, I do not have any objections against renaming to SelectChildren()

Thanks for help.

 

[VZ]

(In [63277]) Add wxTreeCtrl::SelectChildren() method.

Add MSW and generic implementation, documentation and change to the sample
showing it.

Closes #11620.