Ticket #11611 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

wxTaskBarIcon menu item event handling at wxOSX/Carbon

Reported by: kosenko Owned by: csomor
Priority: normal Milestone:
Component: wxOSX-Carbon Version: 2.9-svn
Keywords: Cc:
Blocked By: Patch: yes
Blocking:

Description

Menu item event handler of wxTaskBarIcon at wxOSX/Carbon 2.9.0 is not called in taskbar sample.

It is because SetMenuItemRefCon from Carbon API saves pointer to wxMenuItemCarbonImpl type but GetMenuItemRefCon reads this pointer as wxMenuItem type.
It looks like this was broken in r55419.
This patch fixed this bug only for taskbar, other calls of SetMenuItemRefCon and GetMenuItemRefCon probably should be reviewed and fixed in the same way.

Attachments

carbon_taskbar.patch download (0.8 KB) - added by kosenko 3 years ago.

Change History

Changed 3 years ago by kosenko

Changed 3 years ago by csomor

  • status changed from new to accepted

thanks for spotting this

Changed 3 years ago by csomor

I'll fix it the other way round, I've checked all SetMenuItemRefCon calls, they usually set the wxMenuItem, so I'll adapt the impl to behave accordingly

Changed 3 years ago by SC

  • status changed from accepted to closed
  • resolution set to fixed

(In [63176]) setting correct refcon in menus (was incorrectly changed to menuimpl), fixes #11611

Note: See TracTickets for help on using tickets.