configure sets -mmacosx-version-min=10.5 on 10.4

[lanurmi]

The configure script creates a Makefile where -mmacosx-version-min=10.5 when run on 10.4. As far as I understand, this doesn't make sense.

[vadz]

Is sw_vers found on your system (according to configure)? And, if it is, what does sw_vers -productVersion return?

[lanurmi]

Yes it is found by configure, and when manually run it returns "10.4.11".

The relevant code in configure is

        OSX_VERSION=`sw_vers -productVersion | grep 10.[0-9]`

which makes me really wonder what's the purpose of grep here, and what's the expected output. (It looks like the expected output is "10.4" for "10.4.11" input, but how could that possibly be achieved with grep?)

However, now that I looked at the configure script more carefully, the reason for -mmacosx-version-min=10.5 would appear to be very simple, i.e.

    else
        # for OS X Cocoa, use 10.5 so we can get 64-bit compile on Snow Leopard
        wxUSE_MACOSX_VERSION_MIN=10.5

Not much to debug there, I just hope someone figures out what's the minimum supported Mac OS X version before wx 3.0 is finished.

[vadz]

The purpose of grep would be to select just one line in the program output but I have no idea why do we do it if there is only one line to begin with.

But the real source of the problem is the test in the next line which compares OSX_VERSION with 10.4. As in your case it's 10.4.11, the comparison fails.

Could you please test if the following patch

configure.in

@@ -1229 +1229 @@
         AC_MSG_WARN([Assuming OS X 10.4, use --with-macosx-version-min to override.])
         OSX_VERSION="10.4"
     fi
-    if test "$wxUSE_OSX_CARBON" = 1 -o "x$OSX_VERSION" = "x10.4"; then
-        # otherwise configure stops on leopard for universal_binary
-        wxUSE_MACOSX_VERSION_MIN=10.4
-    else
-        # for OS X Cocoa, use 10.5 so we can get 64-bit compile on Snow Leopard
-        wxUSE_MACOSX_VERSION_MIN=10.5
-    fi
+
+    case "$OSX_VERSION" in
+        10.4* )
+            wxUSE_MACOSX_VERSION_MIN=10.4
+            ;;
+
+        * )
+            if test "$wxUSE_OSX_CARBON" = 1; then
+                # otherwise configure stops on leopard for universal_binary
+                wxUSE_MACOSX_VERSION_MIN=10.4
+            else
+                # for Cocoa, use 10.5 to be able to compile it in 64 bits too
+                wxUSE_MACOSX_VERSION_MIN=10.5
+            fi
+            ;;
+    esac
 fi
 
 NEEDS_GCC40="no"

helps? You'll need to regenerate configure by running autoconf after applying it (or you can edit the corresponding part of configure manually if you're not afraid to look at its horrible code).

TIA!

[lanurmi]

Yes, your patch fixes the problem. Thanks.

I tried with ../configure --with-osx_cocoa --enable-debug, and now Makefile has -mmacosx-version-min=10.4, and the whole trunk compiles, too.

[VZ]

(In [62997]) Correct wxUSE_MACOSX_VERSION_MIN setting when running under OS X 10.4.

sw_vers outputs e.g. 10.4.11 under 10.4 so comparing its result with just 10.4
is wrong, match it against "10.4*" using case instead to ensure that 10.4.11
is indeed recognized as 10.4.

Closes #11579.