Ticket #11494 (closed defect: fixed)
FIX: GetPageInfo being called incorrectly on OSX
| Reported by: | SnowLeopard | Owned by: | csomor |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | wxOSX-Cocoa | Version: | 2.9-svn |
| Keywords: | OSX Printing | Cc: | |
| Blocked By: | Patch: | yes | |
| Blocking: |
Description
According to the documentation for wxPrintout::OnPreparePrinting:
Called once by the framework before any other demands are made of the wxPrintout object.
This gives the object an opportunity to calculate the number of pages in the document, for example.
On Windows this holds true, but on OSX (in wxMacPrinter::Print) wxPrintout::GetPageInfo is called *before* OnPreparePrinting. This contradicts the documentation and makes it so that if your printout object calculates the page range in OnPreparePrinting (as the documentation recommends), then the print operation will either fail or have unexpected behavior.
Attached patch moves the call to GetPageInfo *after* OnPreparePrinting is called (just like the similar Print function in "printwin.cpp"). Works fine with my custom printout object now.
Attachments
-
update.diff
(1.4 KB) - added by SnowLeopard
4 years ago.
- patch file
-
wxOSX_print.patch
(2.2 KB) - added by Auria
3 years ago.
- An updated version that applies cleanly on newer revisions of trunk
