Ticket #11420 (closed enhancement: fixed)

Opened 10 months ago

Last modified 7 months ago

Support for themes on ownerdrawn menu

Reported by: malcompl Owned by: vadz
Priority: normal Milestone:
Component: wxMSW Version: 2.9-svn
Keywords: wxMenu Cc:
Blocked By: Patch: yes
Blocking:

Description

Patch added support for themes on ownerdrawn menu.
The menu looks like a native, but to ensure full compliance apperance with the native menu still missing a few things:

  • misalignment of accel text
  • draw correct std check/bullet mark if item is check/radio and bitmap is not set

I will be work on this problems in next separate patches.

Attachments

uxmenu.patch download (35.9 KB) - added by malcompl 10 months ago.
calcpos.patch download (3.7 KB) - added by malcompl 9 months ago.

Change History

Changed 10 months ago by vadz

  • owner set to vadz
  • status changed from new to accepted

Thanks for the patch, before looking at it: do I understand correctly that it's for the "owerdraw" branch (and not for the trunk)?

Changed 10 months ago by malcompl

Yes, it's for the "ownerdraw-refactor" branch.

Changed 10 months ago by malcompl

Changed 10 months ago by malcompl

Correct small bug and added support for pseudo menu themes on Windows XP.

Changed 9 months ago by vadz

  • status changed from accepted to closed
  • resolution set to fixed

Applied with a couple of very minor changes, thanks (and sorry for the delay).

Looking forward to the next patches and to merging the ownerdraw-refactor branch into trunk!

Changed 9 months ago by malcompl

  • status changed from closed to reopened
  • resolution deleted

Small patch for resolve the 2 problems:

- The text is one pixel too low in owner-drawn case.
- The check mark is one pixel too high.

Changed 9 months ago by malcompl

Changed 9 months ago by VZ

  • status changed from reopened to closed
  • resolution set to fixed

(In [62721]) Fix off by 1 errors in owner-drawn menu drawing code in wxMSW.

The label was offset by 1 pixel vertically and the check marks were 1 pixel
too wide compared to the native ones under XP, correct this.

Closes #11420 (again).

Changed 7 months ago by VZ

(In [63223]) Use theme functions for drawing owner-drawn menus.

This makes the menu items with custom attributes or bitmaps look more native,
especially on post-XP systems.

Closes #11420.

Changed 7 months ago by VZ

(In [63227]) Fix off by 1 errors in owner-drawn menu drawing code in wxMSW.

The label was offset by 1 pixel vertically and the check marks were 1 pixel
too wide compared to the native ones under XP, correct this.

Closes #11420 (again).

Note: See TracTickets for help on using tickets.