Generic listctrl in report mode on Mac does not create header

[dconnet]

Compile the listctrl sample on Mac
- Click View->Mac: Use Generic Control
- View->List view
- View->Report view
Note: No header.
- Turn generic control off
- toggle list/report modes to recreate list, header appears

In version 2.8.10, a header does appear.

[vadz]

At least with wxOSX/Cocoa (which, I think, always uses the generic implementation) the header never appears at all. This is indeed a bad problem.

[SnowLeopard]

This is (maybe) a sizer issue, although for the life of me I can't figure out the fix.

I tracked this down to "src/generic/listctrl.cpp", line 4312.

In the function "CreateOrDestroyHeaderWindowAsNeeded", if I change this line:

GetSizer()->Prepend( m_headerWin, 0, wxGROW );

to this:

GetSizer()->Prepend( m_headerWin, 1, wxGROW );

then the header control appears, although now its height is huge. My only guess is that the "wxGROW" parameter is being ignored and the headerctl is not being horizontally stretched unless I tell it to be vertically stretched too (by changing 0 to 1 in the second parameter). That makes no sense, but that appears to be what's happening. I tried every sizer hackery I could think of, but I couldn't get this control to stretch horizontally unless I made it stretch vertically too (which of course looks awful). I hope this helps.

P.S.
I'm using Cocoa, so I assume wxOSX just always uses the generic list control.

[SnowLeopard]

Patch file

[SnowLeopard]

Yes, this was a sizer issue. By adding a line to tell the main sizer of the header control's minimum height, it is now working under OSX. Attached is a patch with this fix.

[SC]

(In [63177]) applying patch, closes #11309

[vadz]

Sorry but this patch just doesn't make sense to me, this call shouldn't be needed because the sizer should already never shrink the header beneath its initial size which is exactly what is being passed to SetItemMinSize() anyhow.

Could anybody please check that this still doesn't work without this patch with the latest svn trunk? I think it really should and if it doesn't we should fix the bug in wxSizer itself and not here.

[talon_karrde]

Replying to vadz:

Could anybody please check that this still doesn't work without this patch with the latest svn trunk?

I've just tested it without the patch (I'm currently using trunk@r63457) and the listctrl headers are shown. FYI we did have this exact problem and the patch had fixed it, but it seems it is no longer needed.

[vadz]

Thanks for testing!

[vadz]

Fix undone in r63662 (but the ticket wasn't modified automatically somehow...).