Opened 11 years ago

Closed 11 years ago

#11193 closed build error (fixed)

2.9.0 release doesn't work with Xcode due to missing file

Reported by: disc Owned by: csomor
Priority: normal Milestone: 2.9.1
Component: old wxOSX/Carbon port Version: 2.9.0
Keywords: Cc:
Blocked By: Blocking:
Patch: yes

Description

Building src/wxWindows.xcodeproj from wxWidgets-2.9.0.tar.bz2 using any supported Xcode results in the following error:

[...]/wxWidgets-2.9.0/src/build/wxWindows.build/Development/static.build/Script-4091C82C0BC9584900699A3E.sh: line 2: [...]/wxWidgets-2.9.0/src/../distrib/mac/pbsetup-sh: No such file or directory

The release doesn't include the root folder "distrib" however the script distrib/mac/pbsetup-sh is needed to (conditionally) copy include/wx/osx/setup0.h to include/wx/osx/setup.h (copying pbsetup-sh over from a branch or trunk solves it).

Note that this particular error occurs with the Xcode IDE only. The command-line xcodebuild doesn't (seem to try to) run the script and instead results in errors related to missing setup.h.

I suggest to include the file in a next release, I would prefer that to having (include/osx/)setup.h in the release (as is done for MSW). Perhaps also rename distrib/mac/ to distrib/osx/ or, because I think the location of pbsetup-sh is somewhat of a misnomer, move the file to e.g. build/script/ or (not yet existing) build/osx/ .

[I took the liberty to set the milestone to 2.9.1, I don't know how near that release is but feel free to change it of course]

Attachments (1)

create-archive.py.patch download (731 bytes) - added by disc 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by csomor

  • Owner set to csomor
  • Status changed from new to accepted

thanks for spotting this, another solution would be to copy the content of the script into the project itself

comment:2 Changed 11 years ago by disc

Embedding the script in the project would work as well, assuming there will still be a single project file in the future. Is that the case? (so not for example a separate project file for osx_iphone which would require duplicating the script code)

Regarding project files, as you know 2.9's wxWindows.xcodeproj needs quite some updating because of moving and renaming files. Is it helpful if I (try to) do this? Or will the project files you use yourself (for Cocoa, Carbon, and iPhone) go into SVN at some point? (so far I was thinking wxWindows.xcodeproj would stay and, eventually, only build osx_cocoa)

comment:3 Changed 11 years ago by csomor

I wanted to create new clean project files from the scratch, using the 3.1 format as basis and using the xconfig files, but I haven't found the time to do so yet

comment:4 Changed 11 years ago by disc

  • Patch set

If there will be more than one project file as you say I think it's best if the script stays as a standalone file instead of repeating it in each project file (or in the future XCConfig files, but they don't seem to allow for a Run Script anyway).
I'm attaching a patch that adds distrib/mac/ to the release archives.

Changed 11 years ago by disc

comment:5 Changed 11 years ago by SC

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [62104]) make sure build script for copying setup.h doesn't get lost, fixes #11193

Note: See TracTickets for help on using tickets.