wxSocketServer::WaitForAccept not waiting for incoming connections

[D39]

i created wxSocketServer and bring him to wait for incoming connection with WaitForAccept(10).
but it returns immediately, without waiting, because there inside exist checking, which always false on my case...
as i think, this should work for wxSocketServer :)

wxSocketBase::DoWait(long timeout, wxSocketEventFlags flags)
{
    wxCHECK_MSG( m_impl, -1, "can't wait on invalid socket" );

    // we're never going to become ready if we're not connected (any more)
    '''if ( !m_connected && !m_establishing )
        return -1;'''

i using svn version with VS2008

[vadz]

Yes, this is clearly wrong, sorry, this check doesn't make sense for a server. I think it should be enough to add a check for !m_server here but it would be great to have a way to test it. Would it be possible for you to make a patch to the sockets sample exposing the problem? This would allow me to fix it much faster.

TIA!

[D39]

Replying to vadz:

Would it be possible for you to make a patch to the sockets sample exposing the problem? This would allow me to fix it much faster.

there is patch for sockets sample:

Index: server.cpp
===================================================================
--- server.cpp	(revision 61671)
+++ server.cpp	(working copy)
@@ -150,6 +150,12 @@
 
 bool MyApp::OnInit()
 {
+	wxIPV4address addr; 
+	addr.Service(1234);
+	addr.Hostname("localhost");
+	wxSocketServer server(addr, wxSOCKET_REUSEADDR);
+	server.WaitForAccept(10, 0); // there should be freeze for 10 sec
+
   if ( !wxApp::OnInit() )
       return false;

[D39]

i found way to live without this function, just:

SetTimeout(10);
Accept(true);

producing same result :)

[VZ]

(In [61726]) Do wait for connection in the server socket.

The code returned immediately from wxSocketBase::DoWait() if it wasn't
connected but it only made sense for the client sockets, not server ones which
could be calling this function precisely in order to wait until a connection
is made.

Also added a test for this bug in the sockets/server sample.

Closes #11107.

[VZ]

(In [61734]) Back port of wxSocket-related fixes from trunk.

This patch combines the changes from the following trunk revisions:

• r61675
• r61676
• r61677
• r61678
• r61685
• r61686
• r61687
• r61688
• r61689
• r61690
• r61696
• r61726

It refactors wxSocketImpl creation to use a Mac-specific version of it in GUI
Mac applications which fixes generation of socket events under Mac (see #11030)
and also fixes bug in wxSocketServer::WaitForAccept() (see #11107).