Opened 6 years ago

Closed 5 years ago

#10900 closed defect (fixed)

src/common/iconbndl.cpp won't compile w/o STREAMS and FFILE

Reported by: alarsen Owned by:
Priority: low Milestone: 2.9.1
Component: GUI-all Version: stable-latest
Keywords: wxUSE_STREAMS wxUSE_FFILE wxIconBundle Cc:
Blocked By: Blocking:
Patch: no

Description

When building wx for an embedded target (wxDFB) I found that iconbndl.cpp now requires wxUSE_FFILE (since r60881) to compile.

Furthermore, not all occurrences of streams are enclosed in #if wxUSE_STREAMS ... #endif

Would it perhaps be possible (or even reasonable) to make wxIconBundle a configure option (since very minimalistic GUIs can do entirely without icons)?

Cheers
Anders

Change History (4)

comment:1 Changed 6 years ago by VZ

  • Resolution set to fixed
  • Status changed from new to closed

(In [61083]) fix compilation without wxUSE_STREAMS (closes #10900)

comment:2 Changed 6 years ago by vadz

I tried to fix compilation without streams with the above commit, please let me know if I overlooked anything. As for disabling it entirely, I think it's not worth it as it's a very simple/small class, especially without the loading part, and it's used in wxTopLevel in many places. I guess we could add wxUSE_ICON to disable the use of icons entirely but I'm not really motivated to do it as IMO savings would be small.

comment:3 Changed 6 years ago by alarsen

  • Priority changed from normal to low
  • Resolution fixed deleted
  • Status changed from closed to reopened

Compilation still fails when wxUSE_STREAMS==1 and wxUSE_FFILE=0
(the latter was not needed before r60881)

comment:4 Changed 5 years ago by VZ

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [63942]) Fix compilation of wxIconBundle in some particular minimal builds.

Let the code compile when wxUSE_STREAMS==1 but wxUSE_FILE and wxUSE_FFILE are
both 0.

Closes #10900.

Note: See TracTickets for help on using tickets.