Opened 12 years ago

Closed 11 years ago

#10171 closed defect (fixed)

wxAuiToolBar WindowStyleFlag bug

Reported by: phi Owned by:
Priority: normal Milestone:
Component: wxAui Version: stable-latest
Keywords: wxAuiToolBar style flag Cc: net147@…
Blocked By: Blocking:
Patch: yes

Description

The wxAuiToolBar code is not consistant about its WindowStyle flags.
They are modified by these methods, but badly:

SetGripperVisible()
SetOverflowVisible()

Also, GetWindowStyleFlag is not implemented, thus its parent (wxControl) returns the flags which is not in sync with the m_style member variable.

The supplied patch resolves those issues.

Attachments (2)

windowflagbug.diff download (1.3 KB) - added by phi 12 years ago.
auibar_style_fix_r59855.patch download (520 bytes) - added by net147 11 years ago.
Fix toolbar border.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by phi

comment:1 Changed 11 years ago by biwillia76

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for the patch. I've applied it to 2.8 and trunk.

Ben

comment:2 Changed 11 years ago by net147

  • Resolution fixed deleted
  • Status changed from closed to reopened

The fix for this applied in changeset r59851 caused a window border to be added to wxAuiToolBar. I've attached a patch to fix this.

Changed 11 years ago by net147

Fix toolbar border.

comment:3 Changed 11 years ago by net147

  • Cc net147@… added

comment:4 Changed 11 years ago by net147

Same problem with r59850 in 2.8 branch.

comment:5 Changed 11 years ago by biwillia76

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed on both. Thanks.

Note: See TracTickets for help on using tickets.